feat(bazel): Add support for SASS #28167
Conversation
This commit adds the appropriate rules to the WORKSPACE for a project that requires SASS support.
kyliau
added
target: patch
|
You can preview 48349a2 at https://pr28167-48349a2.ngbuilds.io/. |
| assets = glob([ | ||
| "**/*.css", | ||
| "**/*.html", | ||
| ]) + [":style_" + x for x in glob(["**/*.scss"])],`); |
There was a problem hiding this comment.
nit: this assertion is too brittle, or the test is too fake.
If you just want to check that the conditional logic for turning on and including the sass content is working, it's sufficient to just assert that it contains **/*.scss
If you want to check that this list comprehension works, then the test needs to at least run a bazel query on the file so that we evaluate the expression
the way it is, many changes to the production code will require test maintenance just to copy across the new string, and the test doesn't check if those changes are correct.
This commit adds the appropriate rules to the WORKSPACE for a project that requires SASS support. PR Close #28167
This commit adds the appropriate rules to the WORKSPACE for a project that requires SASS support. PR Close angular#28167
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit adds the appropriate rules to the WORKSPACE for a project
that requires SASS support.
Followup PR: Add
.scssfiles to bazel-schematics integration test.The work is pending #28166 to be merged.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information